Post All Winamp 5.666 Core Bug Reports In This Thread

[DrO]

aye though something which helps to fix the issue is better than nothing which was the thing I though I wasn't going to be able to do. I've a few ideas on what's causing it but like you mention is too bad there's not more time. thanks for trying out the test build.

[Aminifu]

that was not a fun one to try to fix and it's still not clear why it's messing up but i've put in alternative handling which should ensure the playlist item is correctly removed the from the tree to then prevent the subsequent issues. Aminifu, am hoping you'll be able to check it out with a beta build i'll be running off later tonight...

The alternative handling seems to have fixed the issue discovered by Dro Chilla. Too bad you don't have more time, the tough ones usually provide the best opportunities to learn stuff.

[DrO]

i don't know, most likely it wasn't deemed viable either due to expected usage levels or licensing. this is why there is a plug-in system so you can have support for things not natively shipped and the point of Winamp is not to ship _everything_ as that just feeds those who claim it's bloated (same for not shipping other skins in the installers, especially for lite).

[lordsilver]

And... why didn't they add APE? MP3, FLAC, WAV and APE are the main audio formats used for music, today.

[DrO]

not without the plug-in authors permission and subject to any agreements (and subsequent licensing payments that would be needed). and considering what's going on with Winamp, no new plug-ins are going to be added and if APE was going to have been added, it would have been done so a long time ago.

[lordsilver]

I have a question for you... Are you allowed to include any plugins in the program? When I'm saying that, I'm thinking at the Monkey's Audio Plugin (APE) that is not included in Winamp.

[lordsilver]

Ok, if you can update it later it's okey to not show that option, I think.... but only if that thing will be updated later .

[Koopa]

There is no simply solution, most of the font code is sadly part of gen_ml and not winamp.exe.

I think it's the best solution for now, he still can provide a newer JTFE after the Winamp 5.666 release, which brings support back.

But if you want to use a feature, which needs code from the library plugin, you can:

1. install the media library plugin and use the feature

2. not install the library and don't have the feature.

That's the best solution, people without ML don't see the skinned window and don't see the bugs, you are seeing and people with installed ML can use the feature.

There is still room for a JTFE update later.

[Edit] too slow

[DrO]

not in the timescale i have to work with as i've clearly stated. and as that is _my_ plug-in (so is not owned by Nullsoft in any form), it is below fixing in-Winamp issues as i can update it outside of Winamp releases. alternatively i just leave it as (which is what i'd prefer to do with the amount of things i still have to do for tomorrow's release).

[lordsilver]

easiest fix for me is to disable skinned mode on lite / no-ml setups and if that's not liked, then i can be contacted after the release for a version that has skinning support when i've the time to look into re-implementing the APIs needed for lite / non-ml setups.
if that's not liked, now is the time to speak up before i make the changes.

Pfff, disable the option? But I liked that thing :|... isn't any chance that you can fix it to work correctly?

[DrO]

i leverage most of the drawing code from the library plug-in (which always should have been in winamp.exe to avoid such issues) and that's why it's acting all weird (as i generally don't test without a library unless someone reports a bug) e.g. no skinned scrollbars. will try to look into it but is likely it'll be fixed after the 5.666 update release that is coming.

alternatively, try using the un-skinned version if using lite as you're effectively crippled in a number of API aspects which having the library (just gen_ml.dll if needed) present implements (which is dumb but is how things evolved and never got fixed to be shared correctly).

[edit]
easiest fix for me is to disable skinned mode on lite / no-ml setups and if that's not liked, then i can be contacted after the release for a version that has skinning support when i've the time to look into re-implementing the APIs needed for lite / non-ml setups.

if that's not liked, now is the time to speak up before i make the changes.

[Koopa]

Hmm, yeah, if you don't have the library installed you don't have the option (I guess the main reason, why DrO is using the ML option, instead of an own in JTFE config was the lack of time and the localization impact)

But I wonder where JTFE then gets the wrong search field font from, if it wasn't set to use the the playlist font?

We have to wait for DrO, sorry.

[lordsilver]

Uhmm... this is the lite version from lite installer, so I don't have any "Media library" (I think). Yes, is Winamp 5.666 build 3512 - Nov 26 2013 and Jump To File Extra v1.31 (Build 1212).

[Koopa]

This is already working fine, is 'Media library uses same font as playlist editor' checked under:

Preferences > Media Library > Apperance ?

And can you verify that you are using Winamp 5.666 Build 3512 and Jump To File Extra v1.31 (Build 1212)?

For me it's just working fine:

http://www.meggamusic.co.uk/shup/1386794532/jumpi.png

[lordsilver]

If I select "Skin the window in the current Winamp skin style" is there any way that the font in the "Jump to file" window be the same as in the playlist???
And another thing, I marked with red where the font isn't showed in the right way, is bigger (like I selected for the playlist, I think)... maybe that "Search for text" thing may not be modified as the playlist font.