Skin Ported for COMMERCIAL software

[Wildrose-Wally]

Interesting preview.

[Nunzio390]

Okay Darren...

We see the Blizzard skin screenshot above, but we also see the preview to the left of it as Wally indicated.

So.. ya gonna tell us what new little nifty thingy you're workin on? Huh? Huh?

[DrO]

The title on the window says it all >> 'Skin Preview'.
It's basically a test plugin for the k-jofol skin plugin i'm slowly working on and i thought as a test/R&D for somethings WAS to re-create the winamp skin for a 'functional' skin preview.

The next stage (hopefully tonight) will be to start hacking the main skin prefs page inorder to intergrate the preview into it

The current test dll is at here if you fancy a look

-daz

[Nunzio390]

Ahhh. Now I see. Well, I do fancy a look, but first I had to download the K-Jöfol player, which of course I didn't have installed on this old Win95 box, but I did manage to "squish" it into the miniscule amount of hard drive space that's available on this old machine (gotta leave room for the Win95 swap file ya know, or I run out of disk space).

Next step: test-run the DLL you're working on. I'll do that later today or tomorrow and let you know what I think.

[DrO]

ok, i'm hijacking this thread it appears (for one last time i think )

same link as in this post but with one difference... no external dialog now but instead have a look at the screenshot below (not all parts are adjusted yet since i have to do them the hard way ) but you get the idea


-daz

[billyvnilly]

i dl your test dl on XP sp1. all my desktop shortcuts flickered in unison w/ WA classic visualization. and in the skin preview, the buttons work for the classic skin.


i really like this idea.

Winamppreferences gets hacked by DrO cos he can... yeah baby yeah!!

[Nunzio390]

And here comes Nunzio, who continues to hijack this thread as well since he really doesn't give a hoot about porting of the Winamp Modern skin, and because what DrO is working on is SOOOO much more interesting...

i dl your test dl on XP sp1. all my desktop shortcuts flickered in unison w/ WA classic visualization. and in the skin preview, the buttons work for the classic skin.

Same here, except of course on my old Win95 box and not XP.

Flickering also occurs within all apps shown running in the taskbar too (but not the systray). Note however, that all flickering stops once music stops.

But the preview is GREAT, Darren!!!!
Question: Will you also be working on previews for modern skins?

Only one thing, and it's really minor - almost not worth mentioning but what the hell, I will, since you are currently working on this! LOL...

The upper-right corner of the skin preview slightly overlaps a bit of the lower-left corner of the text on its right, as seen in your screenshot above, and in mine here and here.

Regardless, keep up the great work, Darren!

And also KEEP that new titlebar text in Winamp Preferences!! ...yeah baby yeah!!!
________________________________________________________________

Re: the K-Jöfol player...

Great little Winamp predecessor that Christophe and Steve were involved in starting there. I actually like it. Really like the way the main window and playlist sorta "glide" in and out, upon opening and closing the app. Really cool.

Too bad no more work is being done on it. Outdated links and very limited file support, as evidenced in this screenshot.

I realize that adding more file-type support is probably not worth it for that player now, especially with Winamp being here. But isn't there anybody around who at the very least can change all the www.kjofol.org dead links to properly point to www.k-jofol.com instead?

[Wildrose-Wally]

k-jofol.com is not any official site, although it probably is the only current and active k-jofol site.
To change the links, a bit of hacking into the exe would be required, and I don't know how the creator (Christophe) would like that idea.

BTW, did you find the Fusion skin for K-Jofol?

[DrO]

Originally posted by billyvnilly
i dl your test dl on XP sp1. all my desktop shortcuts flickered in unison w/ WA classic visualization. and in the skin preview, the buttons work for the classic skin.

there's some issues with the drawing that i need to fix

Originally posted by Nunzio390
Flickering also occurs within all apps shown running in the taskbar too (but not the systray). Note however, that all flickering stops once music stops.

that actually narrows it all down

Originally posted by Nunzio390
The upper-right corner of the skin preview "slightly overlaps" a bit of the lower-left corner of the text on its right, as seen in your screenshot above, and in mine here and here.

yeah, still need to get the placement of those text blocks adjusted, since the information text controls all have an index of -1, it makes things a bit trickier to get the correct one but it'll be fixed later today as well as a few more little tweaks to the general layout.

with the above tweaks/fixes i also aim to get the rest of the main window repduced for an officially useable version. for modern skins the aim currently would then to just show a default image or to use the preview image in the skin (assuming there is one otherwise it will fallback to the first case).

the plan from there just to show it can be done is to make an extended preview which will reproduce the eq,pl,video and do a gen window preview (but that would come a bit later since this plugin has already answered the majority of the skinning questions i've initially had)

-daz

[Nunzio390]

@ Wally...

BTW, did you find the Fusion skin for K-Jofol?

Nope. I looked and looked but never could find that one.
You're joking, right? It was the first one I looked for, and I think you already knew that. (you sly little devil)

The site may not be "official" but I still think it would be nice if links in the player were updated to point to it.

btw (and correct me if I'm wrong)... although the K-Jöfol site has a unique domain name (k-jofol.com), I assume that it is an extension of your site (fusionamp.com). Right? The layout is almost identical at each location, and the same tabbed menuing leads from one site back to the other. Actually, I like the layout at both sites because it's based on the old Winamp.com site layout prior to when the new Winamp.com site came online back in December of last year. I miss the old Winamp.com. I thought it was a lot nicer than what is here now.

Since k-jofol.com is the only active K-Jöfol player site that currently exists, and since the download of the player is offered through that site, why don't you just drop Christophe a note to ask for permission to change the links in the player options/preferences (and also to get rid of the now-dead registration link/nag window too)? I'm sure he won't mind. Then, if DrO is up to it, he can probably very easily make the fixes (or someone else for that matter).

@ Darren...

Originally posted by Nunzio390
Flickering also occurs within all apps shown running in the taskbar too (but not the systray). Note however, that all flickering stops once music stops.

that actually narrows it all down

Yep. I figured it might. That's why I brought it to your attention.

with the above tweaks/fixes i also aim to get the rest of the main window repduced for an officially useable version. for modern skins the aim currently would then to just show a default image or to use the preview image in the skin (assuming there is one otherwise it will fallback to the first case).

the plan from there just to show it can be done is to make an extended preview which will reproduce the eq,pl,video and do a gen window preview (but that would come a bit later since this plugin has already answered the majority of the skinning questions i've initially had)

Awesome! Sounds great! Keep "plugging" away there! ("plugin" pun intended)

[DrO]

billyvnilly: fixed that flicker with one simple line of code (it had been fine before when i was using the external dialog since it was always shown but the changes meant that the preview was trying to draw to a window not there and hence the issue). moral of the bug is that i should test things with winamp playing before releasing

Originally posted by billyvnilly
and in the skin preview, the buttons work for the classic skin.


i really like this idea.

as soon as i started making it i thought having a functional preview would be good to have (and it means i can play around with image handling that bit more ).

Originally posted by wildrose-wally
k-jofol.com is not any official site, although it probably is the only current and active k-jofol site.
To change the links, a bit of hacking into the exe would be required, and I don't know how the creator (Christophe) would like that idea.

any alterations would require a new installer (good thing we've got nsis now ) and either editing the exe or making some rather hackish plugin (since it uses winamp plugins iirc) to alter things when shown (the later is not ideal since it is a bit brute force but most winamp things i do are that way ) personally the first option is easy/better imho.

there's no harm in making up a new installer (even if it's just for me to improve my nsis skillz ).

Originally posted by wildrose-wally
Awesome! Sounds great! Keep "plugging" away there! ("plugin" pun intended)

hehe, i should change my nick to DrP(lugin)

[edit]uploaded a fixed build to the same place as before[/edit]

-daz

[d3x7r0]

DrO that plug is loking SWEET, can't wait to try it in full.

Just one thing I noticed (and I bet you know this): besides the overlaping of the text I natice that the skins changes when you click on top of it (regular behaviour) so that way the preview is rather useless.

Btw can I make a sugestion? Can't you try to change the link in the prefs to actually point to a hidden prefs page completely remade by you? could be a lot easyer than hacking the existing one but than again it could be quite a pain :?

[DrO]

yeah, clicking on the list changes things (still to alter that with a few different options ie click to preview, double-click to preview, alt/ctrl+click, you get the idea - still to decide on that aspect.

Btw can I make a sugestion? Can't you try to change the link in the prefs to actually point to a hidden prefs page completely remade by you? could be a lot easyer than hacking the existing one but than again it could be quite a pain :?

i did think of that but having the preview on the main page is more useful i think. however, i do aim to make a sub page/tab which will allow for a full skin preview instead of just the main window as for easyness, it's about the same for both options (but for the current way i already had the code made so it was easy )

-daz

[Wildrose-Wally]

Originally posted by Nunzio390
btw (and correct me if I'm wrong)... although the K-Jöfol site has a unique domain name (k-jofol.com), I assume that it is an extension of your site (fusionamp.com). Right? The layout is almost identical at each location, and the same tabbed menuing leads from one site back to the other. Actually, I like the layout at both sites because it's based on the old Winamp.com site layout prior to when the new Winamp.com site came online back in December of last year. I miss the old Winamp.com. I thought it was a lot nicer than what is here now.

Since k-jofol.com is the only active K-Jöfol player site that currently exists, and since the download of the player is offered through that site, why don't you just drop Christophe a note to ask for permission to change the links in the player options/preferences (and also to get rid of the now-dead registration link/nag window too)? I'm sure he won't mind. Then, if DrO is up to it, he can probably very easily make the fixes (or someone else for that matter).

The first K-Jofol page was another page on fusionamp.com. When I added the skin tutorial, I registered the domain name, gave the page a new color scheme and once again K-Jofol has its own site.

I have tried to contact Christopher in the recent past, but so far he has not answered.

@DrO
The preview is available through preferences, but when you go directly to the skin browser from the main menu, the default shows.

[DrO]

Originally posted by wildrose-wally
@DrO
The preview is available through preferences, but when you go directly to the skin browser from the main menu, the default shows.

easy one to fix that

btw i've been dabbling with installers and almost got a nsis version fully done (still needs some nice icons/images to brand it better and a few more files to go in)

-daz