Announcement

Collapse
No announcement yet.

Album Art Viewer Plugin v1.03 (17/12/2013)

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • n2jtx
    replied
    Here it is December 2022 and I just install 1.03 on the final Winamp version released earlier this year. Amazed the plugin still works though I have written two myself that still function. Guessing the API has not really changed.

    Leave a comment:


  • MrSinatra
    replied
    impressed TT, kinda shocking windows can get a BSOD from a winamp plugin / resolution issue tho.

    Leave a comment:


  • krokyk
    replied
    Hi all, I've been a winamp user since I don't even remember and was never satisfied with any other player... My library is quite large, full of album art and info so...

    Is there a way (I have 1.1 version) to increase the font size in the album art window? It's nice that the pic scales to the windows size, but the text remains tiny... I'd like to put that window on my TV screen while we listen to the music in the background and want it to be readable even from a few meters...

    Is there a possibility to also display the track name in addition to the other fields (and maybe remove some fields, like Rating)? In other words, how can customize it?

    Leave a comment:


  • thinktink
    replied
    Version 0.7
    • Fixed crash on screen resolution change / resize.
    • Skinned menu that pops up when you context(right)-click the album art window.


    Attached.

    Had to "upgrade" the original source project to MSVC2010 so I've included it with the source.
    Attached Files

    Leave a comment:


  • thinktink
    replied
    Crash issue discovered with my update version.

    So, at work about 2 days ago I found that Winamp would crash whenever I changed my monitor configuration or refreshed my secondary monitor. It also would crash out when I started the SysInternals BSOD fakeout Screensaver.

    At home, Winamp would also crash out when TF2 went full screen initially. I could restart Winamp with TF2 still open in the background after it crashed and then continue playing TF2 going back and forth without additional crashes. Just when starting TF2.

    The crash dump was the same with same screwed up call stack report, something in albumart.w5s. I tried removing all my plugins dealing with Album Art but it had no effect, same crash out, just without any of my plugins installed.

    2 days ago I had enough and finally started Winamp with the WinDebug utility that came with the Microsoft SDK, which finally showed a usable call stack report, it was originating from my updated version of this plugin. >.<

    Today I finally compiled debug build, downloaded the BSOD screensaver, and had a look:

    Inside the dialog proc handler for the gen embed window that displays the album art I found that Windows Message WM_DISPLAYCHANGE was being allowed to fall through the [case] statement into WM_USER (pseudo WM_WA_MPEG_EOF for gen embed windows apparently) message handler. This is actually a smart move as whenever a change in the Winamp skin is made the album art needs to be refreshed so that the display window will be redrawn with the new background color of the skin. There's just one problem with this, WM_DISPLAYCHANGE is not just sent only for skin changes, it's also sent by Windows itself to App level windows to indicate that the screen resolution has changed. https://docs.microsoft.com/en-us/win...-displaychange The difference between the two event sources is that the LPARAM of WM_DISPLAYCHANGE is 0 for skin changes but a combo of the new screen resolution vectors for actual screen changes (ie, not 0). In the code for handling WM_USER it tests the LPARAM for 0 to see if it points to the filename of the playing file as would usually be the case for WM_USER, but not for WM_DISPLAYCHANGE on skin changes (which would be 0). So now, when WM_DISPLAYCHANGE is sent to the gen embed window BY WINDOWS the LPARAM is not 0 but a size vector, but it's not 0 and it doesn't point to a filename. Blamo, crash.

    I downloaded the previous version to see if it was my fault when I updated but it wasn't, it was present before I messed with it.

    I have a build that sets LPARAM to 0 before falling through into the WM_USER case handler that no longer crashes. I will see about publishing an update soon.

    Leave a comment:


  • mattdm11
    replied
    so V1.1 doesn't work with 5.8?

    1.03 does look pixellated, but I thought that was a Winamp issue and not a plugin issue, am I wrong?

    Leave a comment:


  • PsyQu1k
    replied
    https://winampplugins.co.uk/gen_classicart/ for every version, I went for a lower version than 1.03 and it fixed the pixelation on scaling.

    This Attached version mentioned by Benski does the trick for me.
    Attached Files

    Leave a comment:


  • MrSinatra
    replied
    color me confused...

    where is v1.1? who is making it?

    if DrO has the source code for 1.1 or 1.03 or whatever, and Will is the orig author and wants it open, shouldn't DrO provide it in accordance with Will's wishes?

    Leave a comment:


  • PsyQu1k
    replied
    Would be great to update version 1.1 for winamp 5.8, v1.03 work but the quality of scaling is no where near v1.1.

    Leave a comment:


  • rwgdjcfp
    replied
    Very nice plugin!

    Leave a comment:


  • Aminifu
    replied
    Originally Posted by MrSinatra View Post
    surely someone must have more recent source code?
    ...
    DrO does and he is working on Winamp plug-ins again (http://getwinamp.com/blog/).

    Maybe he can be persuaded to give thinktink a copy or incorporate thinktink's improvement himself.

    Leave a comment:


  • MrSinatra
    replied
    surely someone must have more recent source code? is it impossible to open the dll somehow and extract it? reverse it?

    (obviously, i'm no coder)

    Leave a comment:


  • thinktink
    replied
    Originally Posted by Aminifu View Post
    I assume you didn't work with the latest version because you don't have it's source code.
    Aye, it's from what Benksi provided.

    Leave a comment:


  • Aminifu
    replied
    Originally Posted by thinktink View Post
    ...
    [*]This is from the 0.5 version, not the latest version 1.03.
    ...
    I assume you didn't work with the latest version because you don't have it's source code. If so, that's a shame because it has some useful updates over the 0.5 version.

    Leave a comment:


  • thinktink
    replied
    Attached.

    Caveats:
    • I'm using different functions to resize the image to get better quality that causes it to run a bit slower. Users on higher-end machines may not notice a speed difference however.
    • This is from the 0.5 version, not the latest version 1.03.


    Includes both the compiled DLL and an NSIS generated installer.
    Last edited by thinktink; 10 February 2022, 06:58.

    Leave a comment:

Working...
X
😀
🥰
🤢
😎
😡
👍
👎