Windows 7 Taskbar Integration plugin v2.0 (14/11/2011)

[TheSaw]

Pawel, can I ask you a favor? Could you write a short tutorial on how to create translations for the "new" system?

[DrO]

something like...

Edit the lng file in any resource editor, such as Restorator, Resource Hacker (ResHack), or Visual Studio 2003/2008, etc.

Note that with some editors, you might have to rename the .LNG files to .DLL first
for them to load properly.

When done, repack the file back into the .wlz, and you're done.

-daz

[Pawel]

Yup, I can do this.
Short tutorial is something like DrO wrote above :P
I can write some more text, with some screenshots (for newbies), but I can start working on it on Wednesday or later...
-Pawel

[TheSaw]

Well not much longer, but just something to put on the wiki, if anyone wants to. (someone already asked, and it would be easier to just point them there)

[DrO]

there's not much to say other than edit in a resource editor - the only thing is that unless it's used as part of a language pack then it won't be used by the plug-in since Winamp won't know about it.

-daz

[DrO]

is there a reason for always installing the example lng file in the plug-ins directory? (just noticed it was there from earlier)

as it seems a bit excessive to do that when most people aren't going to even need it since it has to be shipped in a lang pack (or manually copied into an existing lang pack), or at least make it optional (defaulted to not be installed) as too much stuff gets dumped in the plug-ins directory without lng files filling it up as well.

-daz

[TheSaw]

Makes sense. I'll remove it.

[DrO]

is anyone else seeing a possible resource leak whilst using this? as the 'handles' count keeps going up on track change and i'm only able to reproduce it with this plug-in present. as i've even gone as far as removing all other gen plug-ins and it still happens.

only noticed it whilst trying to track down a resource leak in the SHOUTcast DSP which persisted even after removing the DSP. or am i just imagining things?

-daz

[TheSaw]

is anyone else seeing a possible resource leak whilst using this? as the 'handles' count keeps going up on track change and i'm only able to reproduce it with this plug-in present. as i've even gone as far as removing all other gen plug-ins and it still happens.

only noticed it whilst trying to track down a resource leak in the SHOUTcast DSP which persisted even after removing the DSP. or am i just imagining things?

-daz

Confirmed. Fuck.

[DrO]

not great for you but good to know it's not me loosing it (more than normal). as i did try messing around with the image settings but that didn't seem to change anything though maybe it's something to do with grabbing artwork or something else (trying to think what it might be that would be grabbed on a track change that could then not be released).

-daz

[TheSaw]

not great for you but good to know it's not me loosing it (more than normal). as i did try messing around with the image settings but that didn't seem to change anything though maybe it's something to do with grabbing artwork or something else (trying to think what it might be that would be grabbed on a track change that could then not be released).

-daz

Found it thanks for reporting it!

For the curious ones: it was in the __CreateShellLink() function, line 269:

code:
hr = psl->QueryInterface(IID_PPV_ARGS(ppsl));

This returned a pointer, which I used outside the function, and forgot to release the COM interface.

[lostinsound]

Thanks for the update. Although I've installed the newest version and I'm still getting this bug I reported earlier:

I'm using the latest build (Alpha build 9) and found a bug. I took the last line of the default text:

%c%%s%Track #: %track% Volume: %volume%%

and moved it so it's the first line and winamp crashed. Turns out the problem is the extra % sign at the end of the line. If I remove that it works fine. In fact if any line other than the last one ends with an extra % sign it crashes.

You replied saying it was fixed but it's still happening for me. The percent sign at the end of any line but the the last line causes winamp to crash when I mouse over the winamp icon in the task bar. Having it at the end of the last line like the default works fine. Can anyone else confirm this?

[DrO]

Found it thanks for reporting it!

For the curious ones: it was in the __CreateShellLink() function, line 269:

code:
hr = psl->QueryInterface(IID_PPV_ARGS(ppsl));

This returned a pointer, which I used outside the function, and forgot to release the COM interface.

That's good you've found it. Though am i having a dumb moment but cannot see a download link for it on the site (as the dropbox link still seems to be the earlier 2.0 download - which as a note mentioned 1.14 during parts of the setup process).

-daz

[TheSaw]

That's good you've found it. Though am i having a dumb moment but cannot see a download link for it on the site (as the dropbox link still seems to be the earlier 2.0 download - which as a note mentioned 1.14 during parts of the setup process).

-daz

Yeah, I didn't upload it. I was in a hurry, as am I now. Here's the .dll
I keep delaying the release because of the custom DPI incompatibility, but I just don't have enough time to fix it. Can't figure it out why it doesn't like some DPI settings, and obviously MS has no info on this. Meh.

[DrO]

well as some sort of compensation you'll be happy the resource leak is now gone for me with that version.

-daz