Embeded Album Art

[thinktink]

Permission Denied.

[thinktink]

While waiting for my zip file to upload, can you tell me how to do that?

The attached is for Windows XP. Might work on Win 7 although not sure at all. Reboot is needed for it to take effect.

[thinktink]

Ok, the link to the zip is below.

http://www.mediafire.com/?bd1a8bcv9cxedba

Mediafire might be blocking it because of detecting the mp3 inside the zip file. Try using a password protected 7z file instead.

[Aminifu]

Mediafire might be blocking it because of detecting the mp3 inside the zip file. Try using a password protected 7z file instead.

That sucks!. I checked and it allowed the download when I first uploaded it. Mediafire will not accept a password protected 7z from me.

I need to look for another file sharing provider.

[thinktink]

Alternatively, you can e-mail it to me in an attachment. I'll pm you my address.

[Aminifu]

Ok, try this link. It should be good for the next 7 days.

http://wikisend.com/download/633208/RepairBin.zip

I don't get MediaFire. The copyrighted and original flags in the files are not set. Are they objecting because of the artist name, alone? I've shared mp3s thru them in the past.

The 7 mp3 and 2 jpg files don't compress very much. The zip is almost 78MB, so it is too large for 1 email attachment for my web service provider to handle. I would have had to split it up. Sorry for the delays, my DSL uplink is so slow and I had to upload to Wikisend twice. The first time did not work, got to the end of the upload and the site stopped responding.

As to the crash, maybe it's a Windows 7 64-bit running a 32-bit program thing. What's weird to me is the crash did not happen during the embed, but well after when the plug-in was not doing anything. After all, it is not used or needed to display the image.

I will put v.1.0 back in the System folder and see what happens with the Nullsoft default skins.

[thinktink]

I just discovered something, maybe it's in the Beta v2 version but if you open a file with an embedded image in the Unified File Editor Pane and try to "Paste" in a new image it crashes Winamp on any skin. This was without my plugin installed. Winamp just goes "bye bye" without any warning.

[EDIT]
Yup, it's in the new Beta v2. I still had a 5.623 install to test also and it didn't crash. But the new Beta v2 even in safe mode crashes.

[Aminifu]

I just discovered something, maybe it's in the Beta v2 version but if you open a file with an embedded image in the Unified File Editor Pane and try to "Paste" in a new image it crashes Winamp on any skin. This was without my plugin installed. Winamp just goes "bye bye" without any warning.

[EDIT]
Yup, it's in the new Beta v2. I still had a 5.623 install to test also and it didn't crash. But the new Beta v2 even in safe mode crashes.

I don't understand the above. What is the Unified File Editor Pane? Are you saying trying to paste in a new image without removing the current embedded image causes an immediate crash?

EDIT:
Nevermind the above questions. Just read what you wrote in the other thread and DrO's response.


Anyway, with the issue I'm having it seems to be related somehow to cPro skins. When using Big Bento everything is stable. Switching back to a cPro skin, clicking thru a few images, then letting Winamp just sit displaying an image and it will eventually crash blaming your plug-in. This is unfortunate for me, since I have become a fan of cPro skins.

Also thanks for the registry adjustment file for reading w5s file version info. I discovered (looking for something else) that I have an app that is able to read file id information from the w5s files. I have 20 w5s files (including other 3rd party w5s files) and it's funny that only 3 of the 20 have any id information in them; yours, one of DrO's, and one of those included in the official full installation package.

[DrO]

unified file editor is the alt+3 dialog. and to save me repeating myself about this crash issue... http://forums.winamp.com/showpost.ph...9&postcount=88

as for this component crashing, i briefly looked at one of the crash reports relating to it and all i could see (didn't have a chance to check it out properly) was it messing up on the parameters it was trying to pass in a call (was like everything had been shifted along by one e.g. was setting 'type' in the width parameter). will have to rummage out proper details from the crash dump when i've a chance (unless it's fixed before then).

[Aminifu]

unified file editor is the alt+3 dialog. and to save me repeating myself about this crash issue... http://forums.winamp.com/showpost.ph...9&postcount=88

Hi DrO,

We have to stop cross posting like this. You are just too quick. I was just editing my post about that question.

[DrO]

I have 20 w5s files (including other 3rd party w5s files) and it's funny that only 3 of the 20 have any id information in them; yours, one of DrO's, and one of those included in the official full installation package.

it's something a few of us would like to have on all of the officially shipped dlls so things can be checked even if parts of Winamp are unable to run (i.e. would massively help koopa's tool).

[thinktink]

...i briefly looked at one of the crash reports relating to it and all i could see (didn't have a chance to check it out properly) was it messing up on the parameters it was trying to pass in a call (was like everything had been shifted along by one e.g. was setting 'type' in the width parameter). will have to rummage out proper details from the crash dump when i've a chance (unless it's fixed before then).

Was it message 13 in api_albumart::_dispatch()?

[DrO]

no idea without re-checking (though i'd be working against the real method names not the dispatch id) which i'm not going to be able to do until tomorrow now (got too much official work that needs to be finished off tonight).

[thinktink]

no idea without re-checking (though i'd be working against the real method names not the dispatch id) which i'm not going to be able to do until tomorrow now (got too much official work that needs to be finished off tonight).

Actually, I would have used it's real method name if it was documented in the copy of the SDK I have. Noticed it by accident during a debug session and saw that it was passing (const wchar_t * filename,const wchar_t * type,wchar_t **mimeType) and returning an int, sometimes 4,1, or 0 depending on what was available from the file.

#ifndef NULLSOFT_WINAMP_API_ALBUMART_H
...SNIP...
		API_ALBUMART_GETALBUMART = 10,
		API_ALBUMART_GETALBUMARTTYPES = 20,
		API_ALBUMART_GETVALIDALBUMARTTYPES = 30,
		API_ALBUMART_SETALBUMART = 40,
		API_ALBUMART_DELETEALBUMART = 50,
		API_ALBUMART_COPYALBUMART = 60,
...SNIP...

After experimenting with it I think it's to let Winamp know what to display for the type of image that the file being referenced holds in the UFIP.

[thinktink]

...
Anyway, with the issue I'm having it seems to be related somehow to cPro skins. When using Big Bento everything is stable. Switching back to a cPro skin, clicking thru a few images, then letting Winamp just sit displaying an image and it will eventually crash blaming your plug-in. This is unfortunate for me, since I have become a fan of cPro skins
...

Ok Aminifu, I have some stuff for you to try out. Inside the attached archive are 3 different versions of the same plugin in a different folder, the names of which only have meaning to me. Manually copy and paste each version into the System directory of your Winamp install and tell me which one from which folder if any doesn't crash.

TIA