Announcement

Collapse
No announcement yet.

[Split] Random title thread whilst moving things around

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • [Split] Random title thread whilst moving things around

    Bug spotted in v5.7 Build 3417 on Win7 x64

    With Winamp closed, Right click on a *.m3u playlist in Windows Explorer, Select "Enqueue & Play". This correctly opens Winamp, adds the new tracks to the bottom of the playlist, and starts the album playing from the first track in the playlist.

    BUT... do exactly the same but when Winamp is already OPEN (but not playing music) and the new items do not start playing.

    Okay... now this is getting weirder. As I am typing this report, I have retried to "Enqueue and Play" while Winamp is open... and this time it DID start playing.. but from the second track in that playlist.

    Hit STOP on Winamp. Now trying more "Enqueue and Play" on that same playlist. And it is loading the tracks into the playlist, but not playing them.

    -=-=-

    I will play with this a bit more to see if I can get closer to the pattern as to what plays and what does not play.

    -=-=-=

    Edit: More weird...

    Winamp Closed. Enqueue and Play the *.m3u file in Windows Explorer. Winamp opens, starts playing from track one in the playlist. While music playing I select the same playlist file and again Enqueue and Play... this time it jumps to playing this new playlist... but from track two. Third, Fourth, and susbsequent times I Enqueu and Play this playlist it is starting from the second track in the playlist.

    Hit STOP in Winamp, and now Enqueue and Play is being ignored. Tracks are being loaded up into Winamp, but not playing. When I scroll the Playlist editor down I see that the second track is selected, but not playing.


    So a couple of bugs in one there I think. The first "enqueue and play" is working correctly when Winamp is closed. The second and subsequent "enqueue and play" is missing the first track out

    Then once Winamp is stopped, the "play" bit of "enqueue and play" is being ignored.

    This is all from Windows Right Click menu in Explorer. Not touching the Winamp GUI here at all.

  • #2
    Hi Batter Pudding,

    Do you have the "Start Winamp playing if it is not already" option selected on the General Preferences - File Types - Shell Options tab?
    Winamp v5.9.2.10042 - Quinto Black CT v3.8 skin
    Windows 11 Home 64-bit v22H2 desktop - Logitech Z906 5.1 speaker system

    Comment


    • #3
      am really tempted to just pull that functionality, as seems to be getting quirkier as time goes on.
      WACUP Project <‖> "Winamp Ramblings" - Indie Winamp Dev Blog

      Comment


      • #4
        And... something else odd....

        I have 535 tracks in the playlist editor window. Winamp is open and playing.

        I RIGHT CLICK a *.m3u playlist in Windows Explorer. Select "Play in Winamp". Current Playlist is correctly wiped and the new nine track playlist is loaded up and starts playing from track one.

        I then Right Click in the Playlist Editor and UNDO until I see my original 535 track playlist. Now here is where it gets interesting.... the same track is still playing from the "new" playlist but is now showing in the scrolling text as "535 - album - trackname" which is, of course, different to track 535 of the freshly recovered playlist.

        Get that? I HEAR the newly loaded track still playing, but the text is describing the track that was at position 535 which I have freshly brought back via UNDO.

        Now the mad-confusion-pixies really kick off... I look at the bottom of the playlist, and drag that last track up to position 534. Glance at the currently playing track name in Winamp and it is showing the tags of track 534 (was 535) of the playlist... while still playing track 01 of the short playlist I had swapped into place just now.

        And freakier.... when it stops playing the track, instead of stepping from track 534 to 535 it now jumps to track 1.


        And if you managed to follow that lot I am amazed!! I think I need to re-write it with some example track names in there. Basically the summary is - messing around with playlist files, "Play in Winamp", UNDO, and then changing file orders seems to be getting a few things confused.

        IMPORTANTLY nothing is crashing.

        Comment


        • #5
          Originally Posted by Aminifu View Post
          Hi Batter Pudding,

          Do you have the "Start Winamp playing if it is not already" option selected on the General Preferences - File Types - Shell Options tab?
          No. Not ticked. See attached image. Maybe this is by design? I just foudn it interesting that "Enqueue and Play" made it play only if Winamp was closed.

          Originally Posted by DrO View Post
          am really tempted to just pull that functionality, as seems to be getting quirkier as time goes on.
          Quirks are fine... as long as there is no crashity crashes with it.

          Just made me laugh I found oddities. I blame the user....
          Attached Files

          Comment


          • #6
            the playlist 'quirks' with going to #1 is expected if things are playing, the playlist changes and you undo as the undo is still seen as a new playlist (due to how the gen_undo plug-in has to work) so that side of things is expected. and the title will get messed up as undo isn't a native action and so things are being kicked into a weird state and playback is trying to cope with what it can find against what's in the playlist editor.

            will check out the enq play stuff later.
            WACUP Project <‖> "Winamp Ramblings" - Indie Winamp Dev Blog

            Comment


            • #7
              Originally Posted by Batter Pudding View Post
              No. Not ticked. See attached image. Maybe this is by design? I just foudn it interesting that "Enqueue and Play" made it play only if Winamp was closed.
              Well, it is selected in my configuration and I'm not having the issues you described. My playlists extension is "m3u8", but that should not matter.


              Originally Posted by Batter Pudding View Post
              Quirks are fine... as long as there is no crashity crashes with it.

              Just made me laugh I found oddities. I blame the user....
              As to the behavior you describe in post #469 , I think that is normal with how things are currently coded. Winamp will continue playing a track when the playlist is changed. The playlist editor code is separate from the main player and will try to populate things from the new playlist. It is not completely sucessful until the song from the previous list ends. Playback always starts from the 1st item in the new list.

              When you use "Enqueue & Play", there are options to have the currently playing song skipped or continue to play. There are no options to control what happens if you just replace the playlist. The default must be to keep the currently playing song playing.

              Edit: DrO's post was not there when I started mine.
              Winamp v5.9.2.10042 - Quinto Black CT v3.8 skin
              Windows 11 Home 64-bit v22H2 desktop - Logitech Z906 5.1 speaker system

              Comment


              • #8
                The playlist editor attempt or attempts (if you use Undo to cycle thru more than 1 list) to read and re-populate things also depends on the General Preferences - Titles - Metadata Reading options.
                Winamp v5.9.2.10042 - Quinto Black CT v3.8 skin
                Windows 11 Home 64-bit v22H2 desktop - Logitech Z906 5.1 speaker system

                Comment


                • #9
                  Originally Posted by DrO View Post
                  the playlist 'quirks' with going to #1 is expected if things are playing, the playlist changes and you undo as the undo is still seen as a new playlist (due to how the gen_undo plug-in has to work) so that side of things is expected. and the title will get messed up as undo isn't a native action and so things are being kicked into a weird state and playback is trying to cope with what it can find against what's in the playlist editor.
                  That all seems sensible to me. I could follow the logic of what was happening, and as I was being awkward with the playlist and my Undo actions what actually happened on screen made sense. As long as you're aware of this, it isn't important enough to spend too much time on.
                  Originally Posted by DrO View Post
                  will check out the enq play stuff later.
                  Ask for more details if the above steps get confusing...

                  What I was of "Enqueue and Play" is logical that is starts up Winamp and then starts to play the track at the start of that playlist. There is also logic to the fact that when I call up a second playlist it would start to play that one instead.

                  To me it is illogical that once Winamp is stopped I now cannot restart it from "Enqueue and Play" from the OS. I read "Enqueue and Play" as a combination of the two commands "Enqueue in Winamp" and "Play in Winamp". Which is why I expected Winamp to jump to the newly loaded up playlist.

                  As to jumping to track two of the second playlist I load up.... I can see where this bug has sneaked in from as there was that bugette you squished for someone else that was related to this. I guess I just found a side effect of that fix.

                  Comment


                  • #10
                    Originally Posted by Aminifu View Post
                    The playlist editor attempt or attempts (if you use Undo to cycle thru more than 1 list) to read and re-populate things also depends on the General Preferences - Titles - Metadata Reading options.
                    After seeing a discussion on here about it, I swapped that setting from the second to the fourth option. So it was on "default" when finding this "undocumented feature" today.

                    I'm going to make sure this really is happening as I noted above. I'll then grab hold of a clean laptop I also have Winamp on and check what is going on there. This PC where the "buG" has appeared is an old "install on top" version whereas the laptop is a cleaner install of the beta. (My Win7 test PC has just gone walkies as it has been sold to someone....)

                    Comment


                    • #11
                      Originally Posted by Batter Pudding View Post
                      To me it is illogical that once Winamp is stopped I now cannot restart it from "Enqueue and Play" from the OS. I read "Enqueue and Play" as a combination of the two commands "Enqueue in Winamp" and "Play in Winamp". Which is why I expected Winamp to jump to the newly loaded up playlist.
                      I agree, but for whatever reason it doesn't unless that option I mentioned is selected.

                      Originally Posted by Batter Pudding View Post
                      As to jumping to track two of the second playlist I load up.... I can see where this bug has sneaked in from as there was that bugette you squished for someone else that was related to this. I guess I just found a side effect of that fix.
                      Try with that option enabled, to see if the behaviour changes.
                      Winamp v5.9.2.10042 - Quinto Black CT v3.8 skin
                      Windows 11 Home 64-bit v22H2 desktop - Logitech Z906 5.1 speaker system

                      Comment


                      • #12
                        Originally Posted by Batter Pudding View Post
                        I'm going to make sure this really is happening as I noted above.
                        I'm sure what you saw is real. I've seen it. With the second option and scrolling through the list, the playlist editor will attempt to start reading metadata and populate things accordingly.

                        With the fourth option, the editor will start reading metadata as each successive list is loaded by the Undo plug-in. You may or may not see things changing depending on how fast you cycle thru lists. But it will not settle down and be correct until the final list is selected and the song that was playing, when the list changes started, has ended.

                        That said, those metadata reading options don't always work as expected. It seems to depend on how files are added to the active playlist (as you know, there are several ways to do this).
                        Winamp v5.9.2.10042 - Quinto Black CT v3.8 skin
                        Windows 11 Home 64-bit v22H2 desktop - Logitech Z906 5.1 speaker system

                        Comment


                        • #13
                          Originally Posted by Aminifu View Post
                          Try with that option enabled, to see if the behaviour changes.
                          Sorry, end of day and brain cooked in the heat here. Which is "That Option"? Do you mean "Start Winamp playing if it is not already"?

                          Yet, if I select "Play in Winamp" from the OS it does start playing the new playlist as expected. The complexities of the English Language....


                          'ANG ON.... just ticked "Start Winamp Playing if it is not already" and that fixed the "bug" where it was jumping to track TWO of the newly loaded up playlist.

                          It also did as you expected - now it does play the new playlist straight away.

                          Aaaaaaaaand.... I untick "Start Winamp playing if it is not already" and my pair of bugs are back. Clearly that option not only stops Winamp from restarting playback, but it also brings in the "play track two" issue. Funky. And well spotted.

                          DrO - I hope you are keeping up here as there is now less to check.
                          Last edited by Batter Pudding; 15 July 2013, 19:39.

                          Comment


                          • #14
                            Originally Posted by Batter Pudding View Post
                            Aaaaaaaaand.... I untick "Start Winamp playing if it is not already" and my pair of bugs are back. Clearly that option not only stops Winamp from restarting playback, but it also brings in the "play track two" issue. Funky. And well spotted.

                            DrO - I hope you are keeping up here as there is now less to check.
                            "Play in Winamp" is from the native code. "Enqueue & Play" is from the JTFE plug-in.

                            JTFE is an excellent addition to Winamp. It is unfortunate that it required a lot of hacks and seemingly illogical options to have it work as well as it does. More work on it is needed, but that will take time.
                            Winamp v5.9.2.10042 - Quinto Black CT v3.8 skin
                            Windows 11 Home 64-bit v22H2 desktop - Logitech Z906 5.1 speaker system

                            Comment


                            • #15
                              Originally Posted by Aminifu View Post
                              "Play in Winamp" is from the native code. "Enqueue & Play" is from the JTFE plug-in.
                              Okay... that kind of explains the differences. I am just reading this as a "dumb user" which is why I thought that "Play" meant "Play" no matter where I read it on the menu.

                              Originally Posted by Aminifu View Post
                              JTFE is an excellent addition to Winamp. It is unfortunate that it required a lot of hacks and seemingly illogical options to have it work as well as it does. More work on it is needed, but that will take time.
                              I can't keep up with all the extra initials. Trying to workout how a NATO Joint Task Force Exercise fits into a Winamp plugin. (http://acronyms.thefreedictionary.com/JTFE)


                              I come at Winamp as a "dumb user" a lot of the time. Using it as a music player \ library. I spend more time enjoying my music than tweaking Winamp. Which means it is easy to get lost among all the plugins, names and tweaks unless one lives it every day. So much of Winamp is "set it and forget" that I rarely go back to change settings. Or even investigate some of the other features...

                              Is JTFE now "Offical" or did I get it from the Enhancements pack? IMHO the more "official" it gets the more it makes sense to "toe the line" and be consistent as to the meaning of "Play". On the flip side of that.... it also makes sense to leave it exactly as it is now as it works even if it is quirky. I can guess that someone put in a request for this at some point in the distant past. So I wouldn't want to break their feature.


                              What is still a minor issue is that playing of the second track in the [second/third/fourth] enqueued playlist...

                              Comment

                              Working...
                              X
                              😀
                              🥰
                              🤢
                              😎
                              😡
                              👍
                              👎