Winamp 5.9 Final Released

[DJ Egg]

Tested on Windows 11!
Mistakes:

After a while, citing an error, it stops by itself and closes the program.
It does not know how to play the HTTPS protocol.
You cannot play online radio streams with FLAC or FLAC.OGG extension!
Please fix these if possible!

https: mp3, m4a & aac - and http: ogg streams are working.
See attached screenshots.

Unfortunately, "Ogg FLAC" still isn't supported (just "ogg" or "flac") :-(
A new Ogg plugin is on the ToDo list.

I can confirm that FLAC streams aren't playing, e.g.
stream.radioparadise.com/flac?.flac

At a guess, support has never been implemented :-(
I'll add it to the ToDo list.

______________________________

[Mikey7]

We're not "using" any of those plugins.

He is saying that users are figuring out how to use *his* plugins in 5.9 against his express wishes. Not the same as saying they're included in the 5.9 package. Personally I think its a bit petty to complain that he made/upgraded plugins for 5.666 (3516) but doesn't want them to work on 5.9 (9999) because he didn't work on that team and doesn't like the new company.

JTFE is not included in the Winamp 5.8 or 5.9 package.

I didn't say it was, merely that it seems to be very popular.

Afaik, the Classic Album Art Viewer plug-in (gen_classicart.dll) is our plug-in.
It was originally coded by Will Fisher (former team member, pmp_ipod coder, etc), is in our Git Repo, and is part of our SDK.
Yes, of course, DrO did make some updates when part of the Winamp team, but I don't know anything else beyond that.

Agreed and in my opinion I think he's complaining about nothing.

I'm not familiar with any of the other plugins you mentioned. Did you mean Waveform Wrapper, or WavPack player?

Thimeo Declipper Winamp plugin (also part of the standalone Stereo Tool) has been around for ages and is *still* available - wonderful tool for normalizing Internet Radio and sound files if not using Replay Gain.

This is Big Clock (originally by NXS) and below that is Waveform Seeker. It's like the seeker bar but in waveform format for easily pinpointing a passage. I don't remember who wrote the original plugin.

[DJ Egg]

He is saying that users are figuring out how to use *his* plugins in 5.9 against his express wishes. Not the same as saying they're included in the 5.9 package. Personally I think its a bit petty to complain that he made/upgraded plugins for 5.666 (3516) but doesn't want them to work on 5.9 (9999) because he didn't work on that team and doesn't like the new company.


I didn't say it was, merely that it seems to be very popular.

Agreed and in my opinion I think he's complaining about nothing.

Thimeo Declipper Winamp plugin (also part of the standalone Stereo Tool) has been around for ages and is *still* available - wonderful tool for normalizing Internet Radio and sound files if not using Replay Gain.

This is Big Clock (originally by NXS) and below that is Waveform Seeker. It's like the seeker bar but in waveform format for easily pinpointing a passage. I don't remember who wrote the original plugin.

Hmm, maybe I misunderstood. I interpreted it as they (not you) were claiming/assuming those plugins are included in the 5.9 package.

We never intentionally set out to break support for a whole heap of 3rd-party plugins, including many others by other plugin authors.

Making them work again for the next release (by fixing the Winamp manifest) is a bug fix - and maintains backwards compatibility.

If only we'd realised sooner that VS2019 broke the manifest (d'oh!), then we obviously wouldn't have needed to mention it :-(


By the way, although I don't use them and aren't familiar with them, those plugins do look nice. Thanks!

[Mikey7]

Hmm, maybe I misunderstood. I interpreted it as they (not you) were claiming/assuming those plugins are included in the 5.9 package.

We never intentionally set out to break support for a whole heap of 3rd-party plugins, including many others by other plugin authors.

Making them work again for the next release (by fixing the Winamp manifest) is a bug fix - and maintains backwards compatibility.

By the way, although I don't use them and aren't familiar with them, those plugins do look nice. Thanks!

The declipper, the lyrics plugin (gen_lyricsplugin.dll), and the original NXS Big Clock are all working as-is under 5.9. He is expressly saying he doesn't want *his" plugins (whatever those might be) to work under 5.9

[DJ Egg]

I'm afraid that's something for executive management and legal departments, not me.

The only relevant code change for this release is (or will be) the manifest fix to make plugins which depend on msvcr90 load again.

If the manifest hadn't been broken during project migration, then nothing would've changed in that respect.

This is precisely why we went from internal beta to RC status before going Final :-)

The first post has been updated accordingly.

[enzo1982]

Winamp 5.9 RC1 Build 9999
* Misc: lame_enc & libsndfile now static links instead of dynamic dll
* Misc: libmpg123, libflac & zlib now static links instead of dynamic dll

Don't want to spoil the party, but static linking of LGPL libraries without providing the source code for your modules is violating the license.

To comply with the LGPL, you need to make it possible for users to replace the LGPL parts with their own versions. One way to do this is to build them as dynamic libraries, the other is to publish the source code of your modules (apparently the affected modules would be in_mod.dll, enc_lame.dll and in_wave.dll in this case).

Unless you have express permission from the mpg123, LAME and libsndfile projects to use them in this way, of course.

[M.D-78 Odysséus]

Today I noticed when trying to close Winamp by the Windows taskbar button that it is not closing by the button and the file playback controls do not appear, it only looks like the title and the Winamp thumbnail on the taskbar.
Anyone else with this problem?

[DJ Egg]

Don't want to spoil the party, but static linking of LGPL libraries without providing the source code for your modules is violating the license.

To comply with the LGPL, you need to make it possible for users to replace the LGPL parts with their own versions. One way to do this is to build them as dynamic libraries, the other is to publish the source code of your modules (apparently the affected modules would be in_mod.dll, enc_lame.dll and in_wave.dll in this case).

Unless you have express permission from the mpg123, LAME and libsndfile projects to use them in this way, of course.

Thanks for the info.

https://news.ycombinator.com/item?id=15871390

https://www.gnu.org/licenses/gpl-faq.html#LGPLStaticVsDynamic

The libs are just unmodified static links, automated via vcpkg in VS2019.
I'm sure our "object files" can be made available "on request".

I guess we'd need to check with the legal dept.

[ECraig]

Each time a track starts it is muted when using Nullsoft WASAPI 0.1 output (5.9 RC1), although the timer shows progress. I have to manually just touch the volume fader to hear the sound, without actually changing the volume. And so happens with each new track in a playlist. Seems like a bug. Only FLAC files seem to work fine.
Also, there are no configuration settings, so does it work in exclusive mode, push or pull?

[Mikey7]

All I can say is that I'm extremely pleased. I was a bit cynical at first but this release has really proven itself. Of course, DJ Egg, myself, and others coming up with plugin alternatives has only sweetened the experience.

The only bugs/glitches are the language pack weirdness such as Equalizer Presets being in an Asian script. The one bug that never got fixed in any release after all these years was in Playlists, being unable to save the column size and position!

I just wanted to say Thanks. The feeling of having a "new" Winamp version again just can't be beat. This is not to take away from the angst of those who use Winamp in different configurations such as WASAPI out instead of DirectSound, etc., and are experiencing issues.

Thanks again to the team!

[M.D-78 Odysséus]

I don't want to be annoying but can someone help me with these two questions?
The preview in the taskbar and the constant freezes, like I hear about 10 to 15 tracks of audios and Winamp freezes.

Here Winamp on the taskbar without the buttons.



Here the frozen Winamp.

[Mikey7]

I don't want to be annoying but can someone help me with these two questions?
The preview in the taskbar and the constant freezes, like I hear about 10 to 15 tracks of audios and Winamp freezes.

Here Winamp on the taskbar without the buttons.



Here the frozen Winamp.

I'm going to ask the obvious questions first: What OS are you running? Presumably you're running Windows, so which version of Windows?

What kind of computer? CPU? RAM?

It is impossible to help you troubleshoot without some preliminary questions being answered. Also, you're screenshots aren't showing any useful information.

[M.D-78 Odysséus]

Windows 11, Core i5 and 16gb of Ram

[Mikey7]

Windows 11, Core i5 and 16gb of Ram

Ok. Are you running Winamp 5.9 "as-is" after installing it? Did you add any external (3rd-party) plugins? Did you make any changes to the Preferences file such as additionally configuring input or output plugins or changing them from the default configuration?

[M.D-78 Odysséus]

Well I modified the manifest as in the post http://forums.winamp.com/showpost.ph...9&postcount=47
And I added some plugins as shown in the images:








I believe this is it.