Tweet
I have found the issue. It's with libopus-file's file handling being pure Ansi and the mindless conversion of input filenames I was doing. Hopefully I'll have something out soon.
-
Try this one out. Attached.
[EDIT /]
In the meantime, I'm going to fix my hex editor so I can open those unicode named files and have a look-see as to what I can do to support true-form unicode tag support. May take a little time.Last edited by thinktink; 4 March 2013, 06:07.Comment
-
-
I think I have it. The tags aren't actually Unicode but a form of MBCS (is what it looks like) and I have Winamp displaying the same characters in the playlist and the info box as my LFS does. It is however a debug version and only partly integrated so it'll take a little bit of time to complete but it does seem I'm on the correct path.Comment
-
Blammo! Unicode tag support. I even tested it with Unicode named files with Chinese metadata.
Attached.
[EDIT/]
Point of note: There's a new version of the opus codec libraries from the website linked to earlier.
Update to the DLLs not required for operation but recommended to update anyway. To update you will need to shut Winamp down first, remove the old DLLs and drop the new versions to the same folder as before. The streaming functions also now supports IRI resources,
Last edited by thinktink; 4 March 2013, 07:58.Comment
-
i'm not following... i thought u already had unicode, and the problem tags were MBCS and you were going to add MBCS?
what actually changed?PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editingComment
-
I exported the Unicode versions of the extended metadata support in the original and last release but the tag support in Opus was pure Ansi. I just assumed that the tag support was only Ansi. I hadn't realized that the Unicode metadata was being translated to and from MBCS which "looks" like regular Ansi if you're not paying close attention. So in the previous versions of the plugin the MBCS data was being sent out as Unicode re-encoded from AnsiStrings instead of as UTF-8 from MBCS and the metadata was garbled and butchered (i.e. "Yuji Ono" instead of "Yūji Ōno" and some other weirdness.)Originally Posted by MrSinatra View PostComment
-
my kudos to you for being able to track down an issue like that. the hardest ones are the ones where the difference is something so slight, hard to see.
so the lesson to be learned here by other plugin devs is to carefully check to see that you are implementing true unicode all the way through the process, and not something less than that, right? (it almost sounds like a music traders nightmare of an analog stage somewhere in the distribution tree
)
how would you phrase it to other devs, or is what you have already said enough? (meaning, to warn them from making the same mistakes?)PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editingComment
-
Actually is was just half ignorance about MBCS and the other half bad assumptions.Comment
-
Ack, I uploaded the wrong version. Previous one had some debug code in it that blocked metadata re-writing for non-unicode named files. Removed bad version.Last edited by thinktink; 4 March 2013, 17:58.Comment
-
This is a beautiful day. Thanks ThinkTink for your great work!
Two quick remarks:
- Some metadata fields are not displayed in Winamp FileInfo (track, year and genre AFAICT). They do appear correctly in XMPlay, Foobar, MediaInfo, TagScanner.
- A minor nitpick about out_ds integration: fade-in/out works on pause and seek, but not on stop.
Comment
-
Please attach the files that aren't working in a zip or 7z archive and I'll take a look.
out_ds crossfades and fadeouts are working for me. I don't know why not for you.Comment
-
Works great.
Actually what I don't like about opus is that all input streams are first resampled to 48 kHz as every Opus file is always 48 kHz.
It is a good thing that the original sample rate is displayed in File info, but in Winamp itself it is always indicated as 48 kHz. Is there any way to change this? I mean, is there any way to get the original stream out of an Opus file without the means of resampling it back to its original sample rate after decoding the 48 kHz Opus core? (Which would be even worse)...
I also wondered why the plugin's DLL is so big which causes a longer load time when running Winamp from a (slow) flash drive...
I also have another suggestion: It would be fine to support Album Art for Opus!
This is also specified already, it's just a BASE64 blob which is stored in a text field named "metadata_block_picture". See example file:
@Winamp Dev team: Are there any plans to include the Opus plugin (or another one) in one of the next Releases "officially"?
Thank for all your great work!!
Best regards,
kzuse
Comment
-
The opus libraries do seem to have a set of resampler functions in them but the documentation on them is cryptic at best. Will look into it further. However, the Opus codec itself is only 48KHz. Audio that's not already 48KHz gets converted to 48KHz before being sent to Opus, that's just the nature of the codec. I saw no point originally in researching resampling ('till you mentioned it.)
As for the album art, I'll take a look. Should've mentioned it sooner though. lol
[EDIT/]
P.S.:
Thanks for the egregiously long test vector.Last edited by thinktink; 4 March 2013, 22:53.Comment
Comment